📐 fix: correct what the adversarial review of the page found
Five auditors read the finished page against the source; a second pass tried to refute each finding. What survived: **The esbuild row was wrong, and dangerously so.** It said esbuild takes "the same settings via tsconfigRaw" as tsc. It does not: esbuild lowers standard decorators only when its own *top-level* `target` is below `esnext`. A `target` inside `tsconfigRaw` sets the `useDefineForClassFields` default and nothing else. I ran it — the decorator survives verbatim and the module throws SyntaxError on import, which is the exact silent passthrough the section blames on oxc. The repo's own vite plugin and toolchain test always passed `target` top-level, so the executed matrix never backed the advice the docs gave. Both halves are now asserted in src/toolchain.test.ts. **"This table is executed by a test" did not cover the oxc row** — the only ✗, and the row the whole section is built around. It cannot be: oxc ships as a native binary with no standalone transform API, which the test file already said in a comment. Fixed on the page and in the README. Reference corrections, each verified against the source: - fromRequest has no …Sync twin; the group blurb claimed every entry did - @IsNotIn does not narrow its field, unlike its five neighbours - @MinDate/@MaxDate take a Date as well as a thunk - @Validate has three parameters, not two; defineRule has four - getConfig() and resetConfig() were missing from a group rendered under the heading "Everything cereale exports" And on the page itself: the vite.config.ts snippet never imported defineConfig, so pasting it failed; and the plugin note omitted that .tsx is excluded by default, which would drop a reader straight back into the 0-test hole the section exists to describe. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SAcqrz3FcadkYr3xG32CjK
This commit is contained in:
+16
-2
@@ -97,8 +97,22 @@ at runtime so it cannot drift.
|
||||
|
||||
The hero's compiler error is not typed into the HTML — `scripts/build-docs.mjs` compiles the
|
||||
snippet with the real `tsc` and writes the verbatim diagnostic into `docs/diagnostics.js`,
|
||||
failing the build if a snippet the page calls a compile error ever compiles. A third snippet
|
||||
that must compile guards against the harness passing vacuously.
|
||||
failing the build if a snippet the page calls a compile error ever compiles. Two more snippets
|
||||
that must compile guard against the harness passing vacuously.
|
||||
|
||||
### Corrected
|
||||
|
||||
The README's toolchain table said esbuild takes "the same settings via `tsconfigRaw`". It does
|
||||
not: esbuild lowers standard decorators only when its **own top-level `target`** is below
|
||||
`esnext`. A `target` inside `tsconfigRaw` sets the `useDefineForClassFields` default and
|
||||
nothing else, so following that advice leaves decorator syntax in the output — the same silent
|
||||
passthrough the section blames on oxc. Both the table and the landing page now say so, and
|
||||
`src/toolchain.test.ts` asserts both halves, so the trap is documented by a test rather than by
|
||||
a sentence.
|
||||
|
||||
Also corrected in the same pass: the toolchain table is described as executed by a test, but
|
||||
the oxc row — the only ✗ — cannot be, because oxc ships inside a native binary with no
|
||||
standalone transform API. The claim now covers the three rows it actually covers.
|
||||
|
||||
### Positioning
|
||||
|
||||
|
||||
Reference in New Issue
Block a user