Say so when Gaia is missing, rather than as 68 000 unmatched stars
With the merge gate in place, a Gaia DR3 outage no longer ships a HYG-only catalogue: the ETL skips the unreachable source, and validateMerge then fails on the survivor count. That is the right outcome and the wrong message: "68 000 HYG stars found no Gaia counterpart" sends the reader looking at the merge. Gaia contributing nothing is now checked first, by name. Two comments said Gaia was best-effort, in data-refresh.yml and on the merge in fetchStars. They now say what happens instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016jxMkwA2rbicdGxHosecYi
This commit is contained in:
@@ -74,6 +74,12 @@ const MAX_HYG_SURVIVORS = 15_000;
|
||||
const TWIN_TOLERANCE_RAD = (1 / 3600) * (Math.PI / 180);
|
||||
|
||||
function validateMerge(stars: StarRecord[]): void {
|
||||
// Checked first and on its own: an unreachable Gaia is skipped rather than thrown, and would
|
||||
// otherwise surface below as "68 000 HYG stars found no counterpart" — true, and no help.
|
||||
assertCondition(
|
||||
stars.some((star) => star.source === 'gaia'),
|
||||
'Gaia DR3 contributed no stars — the archive was unreachable or returned nothing, and a catalogue without it is not one to publish.'
|
||||
);
|
||||
const survivors = stars.filter((star) => star.source === 'hyg').length;
|
||||
assertCondition(
|
||||
survivors <= MAX_HYG_SURVIVORS,
|
||||
|
||||
Reference in New Issue
Block a user