Frame a giant so its disc sits inside the ring its neighbours are named on
The system view names a star's neighbours on a ring at 0.74 of the view's tighter half-extent, whatever the star. A giant was framed to fill the frame, 2.4 radii out, which the three-radius closest approach then overrode, so it settled at 3 radii with its disc projecting to 0.758 of the half-extent: in the app, Betelgeuse's disc was 379 px on a 1 000 px view against the 370 px ring, and HD 39374 and HD 38118 were printed on it at about 1.3:1 contrast. The star's term in the framing distance now places its silhouette, asin(R / d), at half the tighter half-extent, which puts the camera 4.4 radii out on a 50° view. Measured on :4302 at 1600 by 1000: Betelgeuse settles at 13.9 AU (closest approach 9.5) with a 250 px disc and Antares at 14.1 AU; the nearest corner of any neighbour's name is 292 px from the centre, so none is on either disc (it was two and one of them before). Closing in to the closest approach can still bring the disc over the names; that is the viewer's choice, not the arrival's. This also gives the star's term a job: at 2.4 radii it never exceeded the closest approach, so dropping it changed nothing (the previous commit's one surviving control). Controls, each failing its named test: the star left out of the framing (1 of 788 failed), the star framed to fill the frame (2 of 788), and the disc taken as flat (1 of 788). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -989,6 +989,8 @@ describe('GalaxySystemSceneComponent camera-flight transitions', () => {
|
||||
expect(radius / SUN_RADIUS_AU).toBeLessThan(760);
|
||||
expect(scene.controls.minDistance).toBeCloseTo(closestApproachAu(radius), 9);
|
||||
expect(scene.controls.minDistance).toBeGreaterThan(9);
|
||||
// Settled where its disc stays inside the ring of its neighbours' names, not pressed up to it.
|
||||
expect(engine.getCamera().position.length()).toBeGreaterThan(1.2 * scene.controls.minDistance);
|
||||
});
|
||||
|
||||
it('draws a star nothing gives a size or temperature for as a grey point, not as the Sun', async () => {
|
||||
|
||||
Reference in New Issue
Block a user